ReStringUtils::base64Encode(): buffer overflow

diff --git a/base/ReStringUtils.cpp b/base/ReStringUtils.cpp
index de2fd59f62fbaa90148e6c59dfdedca18e31b328..4f729c81f94c6d293956fd0cb5a35c47684f19b4 100644 (file)
--- a/base/ReStringUtils.cpp
+++ b/base/ReStringUtils.cpp
@@ -70,7 +70,7 @@ QByteArray& ReStringUtils::base64Decode(const char* input, int inputLength, QByt
  * @param output        OUT: the encoded string
  * @return              <code>output</code> (for chaining)
  */
-QByteArray& ReStringUtils::base64Encode(uint8_t const* input, size_t inputLength, QByteArray& output) {
+QByteArray& ReStringUtils::base64Encode(uint8_t const* input, int inputLength, QByteArray& output) {
   output.resize(4 * ((inputLength + 2 - ((inputLength + 2) % 3)) / 3));
   uint8_t* outCursor = reinterpret_cast<uint8_t*>(output.data());
   while (inputLength-- > 3) {

diff --git a/base/ReStringUtils.hpp b/base/ReStringUtils.hpp
index 007da6dc7d658f03dce3be161bb7c5bde3a201af..28e3c39528c130af5d2c743a220385e1db5dfd1d 100644 (file)
--- a/base/ReStringUtils.hpp
+++ b/base/ReStringUtils.hpp
@@ -45,7 +45,7 @@ protected:
 class ReStringUtils {
 public:
        static QByteArray& base64Decode(const char *input, int inputLength, QByteArray& output);
-       static QByteArray& base64Encode(const uint8_t *input, size_t inputLength, QByteArray& output);
+       static QByteArray& base64Encode(const uint8_t *input, int inputLength, QByteArray& output);
        static QByteArray& chomp(QByteArray &string, char cc = '\n');
        static int countChar(const char* line, char cc);
        static int count(const char* source, const char* item);